Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caddy startup #89

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

henrirosten
Copy link
Collaborator

Move caddy environment file from /run/caddy.env to /var/lib/caddy/caddy.env to make it persist reboots. Before this change, caddy service would fail to start after the first boot due to missing caddy environment file.

Move caddy environment file from `/run/caddy.env` to
`/var/lib/caddy/caddy.env` to make it persist reboots. Before this
change, caddy service would fail to start after the first boot due to
missing caddy environment file.

Signed-off-by: Henri Rosten <[email protected]>
@henrirosten henrirosten marked this pull request as ready for review February 29, 2024 12:52
@henrirosten henrirosten requested review from ktusawrk and a team February 29, 2024 12:52
Copy link
Member

@karim20230 karim20230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Collaborator

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something for the commit message. As per https://cloudinit.readthedocs.io/en/latest/reference/modules.html#write-files, Module frequency is once-per-instance, so write_files items only get written once.

TIL!

@henrirosten henrirosten merged commit 0f81c5f into tiiuae:main Feb 29, 2024
2 checks passed
@henrirosten henrirosten deleted the fix-caddy-startup branch March 1, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants