Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote x86 hydra builder: Add Yubikey provisioning #80

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

mkaapu
Copy link
Contributor

@mkaapu mkaapu commented Feb 20, 2024

  • Environment for Yubikey provisioning (legacy Hydra builds)
  • Add Yubikey signer accounts for build3 and build4

@mkaapu
Copy link
Contributor Author

mkaapu commented Feb 20, 2024

Provides environment for provisioning Yubikey as described here:
https://github.com/tiiuae/scs-pki-research/tree/main/yubikey

As Hydra is legacy system, this is not full automation of signing server with Nix, just providing environment where signing server can be set.

Tested on build4 Ficolo machine.

@mkaapu mkaapu requested review from cazfi and alextserepov February 20, 2024 16:09
@tervis-unikie tervis-unikie self-requested a review February 20, 2024 16:27
Copy link
Contributor

@tervis-unikie tervis-unikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect subject capitalization.
Take githooks into use and check github actions for warnings when making a PR.

@mkaapu mkaapu changed the title remote x86 hydra builder: add Yubikey provisioning remote x86 hydra builder: Add Yubikey provisioning Feb 21, 2024
- Environment for Yubikey provisioning (legacy Hydra builds)
- Add Yubikey signer accounts for build3 and build4

Signed-off-by: Marko Kaapu <[email protected]>
@mkaapu
Copy link
Contributor Author

mkaapu commented Feb 21, 2024

Incorrect subject capitalization. Take githooks into use and check github actions for warnings when making a PR.

Thanks @tervis-unikie for reminding. I rebased with main, installed git hooks and fixed commit subject.
However, commit message checking seems to fail for some other reason:

Error: Failed to retrieve commits (https://api.github.com/repos/tiiuae/ghaf-infra/pulls/80/commits)
Error: API rate limit exceeded for 20.172.5.33. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)
Error: Process completed with exit code 7.

@mkaapu
Copy link
Contributor Author

mkaapu commented Feb 21, 2024

OK. I just re-run commit message check. It was just probably some internal GitHub error. Maybe too many checks running parallel, no idea really..
But check passed with re-run.

@mkaapu mkaapu requested a review from tervis-unikie February 21, 2024 14:07
@mkaapu mkaapu merged commit 7789ce1 into tiiuae:main Feb 21, 2024
2 checks passed
@mkaapu mkaapu deleted the pr-setup-signing branch February 21, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants