Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx-configuration and acme #77

Merged
merged 1 commit into from
Feb 19, 2024
Merged

nginx-configuration and acme #77

merged 1 commit into from
Feb 19, 2024

Conversation

karim20230
Copy link
Member

  • Added configuration to enable ACME for himalia.vedenemo.dev virtual host.
    -Instead of Certbot, we are already using ACME (Automated Certificate Management Environment) for managing our HTTPS certificates
  • Implemented configuration to force SS
  • Set default email for ACME to "[email protected]" for testing purposes.

@karim20230
Copy link
Member Author

changes need to deploy!

@karim20230 karim20230 requested review from cazfi and joinemm February 16, 2024 15:17
@karim20230
Copy link
Member Author

ah build fails

@karim20230 karim20230 changed the title nginx-configuretion and acme nginx-configuration and acme Feb 16, 2024
@karim20230
Copy link
Member Author

build ok

@karim20230
Copy link
Member Author

deployed successful!

@karim20230 karim20230 merged commit 9366f86 into tiiuae:main Feb 19, 2024
1 check passed
@karim20230 karim20230 deleted the ngnix-config-ssl branch February 19, 2024 12:24
fayadf pushed a commit to fayadf/ghaf-infra that referenced this pull request Oct 2, 2024
@karim20230
inginx config and acme added (tiiuae#77)
75c3d4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joinemm joinemm joinemm approved these changes

@cazfi cazfi Awaiting requested review from cazfi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karim20230 @joinemm