Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-push formatting checks #41

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix pre-push formatting checks #41

merged 2 commits into from
Dec 19, 2023

Conversation

joinemm
Copy link
Collaborator

@joinemm joinemm commented Dec 19, 2023

Current main branch does not pass nix flake check as the formatting is wrong in prbuilder configuration. This passed our automatic checks because the pre-push task silently reformats the files before running nix flake check. Thus the pre-push checks pass even though files have been changed.

nix fmt has no --check option so this was changed to alejandra --check . nix fmt -- --fail-on-change.

For tasks.py, added some commas so black will format the aliases consistently in the same way. Without this the wrapping would depend on the line length. Imports have also been sorted with isort.

Signed-off-by: Joonas Rautiola <[email protected]>
tasks.py Outdated Show resolved Hide resolved
@joinemm joinemm merged commit 698b378 into main Dec 19, 2023
1 check passed
@joinemm joinemm deleted the reformat branch December 19, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants