Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-artifacts.sh: Fix resume download #313

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

henrirosten
Copy link
Collaborator

  • Use wget --continue option to resume downloading a partially downloaded remote directory.
  • We also need to use --no-if-modified-since, because otherwise wget would consider a partially downloaded file a complete due to --timestamping

After these changes, one can abort get-artifacts.sh (e.g. with ctrl-c) and continue the download later - the script will resume the download as long as the output directory from the earlier attempt is not removed.

@henrirosten henrirosten marked this pull request as ready for review November 29, 2024 12:00
@henrirosten henrirosten requested a review from a team November 29, 2024 12:01
@karim20230
Copy link
Member

Testing in progress

@karim20230
Copy link
Member

Testing in progress

Tested seems the issue fixed!

@henrirosten henrirosten merged commit 6be2cb6 into main Nov 29, 2024
6 checks passed
@henrirosten henrirosten deleted the fix-get-artifacts-dl-resume branch December 2, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants