Support per-environment builder ssh keys #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create and use a per-environment builder ssh key unless external builders are used in the given ghaf-infra instance. Builder ssh key used to access the external builders is still stored and accessed from the persistent resource group. After this change, ghaf-infra configurations that don't use external builders (e.g. 'release') will create and use new builder ssh-keys on every new ghaf-infra deployment. Signed-off-by: Henri Rosten <[email protected]>
flokli
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create and use per-environment builder ssh key unless external builders are used in the given ghaf-infra instance. Builder ssh key used to access the external builder(s) is still stored and accessed from the persistent resource group.
After this change, ghaf-infra configurations that don't use external builders (e.g. 'release') will create and use new builder ssh-keys on every new ghaf-infra deployment.