Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial monitoring server configuration #26

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Add initial monitoring server configuration #26

merged 1 commit into from
Nov 23, 2023

Conversation

joinemm
Copy link
Collaborator

@joinemm joinemm commented Nov 22, 2023

Adds monitoring VM running Grafana and Prometheus, that monitors build4 and binarycache using node_exporter metrics

@joinemm joinemm requested a review from henrirosten November 22, 2023 14:22
henrirosten
henrirosten previously approved these changes Nov 23, 2023
Copy link
Collaborator

@henrirosten henrirosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I have not tested this.
@joinemm :
I assume you get a warning on installing the new monitoring configuration, since it doesn't have secrets.yaml, so the host key decryption should fail:

subprocess.run(

@joinemm
Copy link
Collaborator Author

joinemm commented Nov 23, 2023

@henrirosten I actually never saw this warning when testing, I was not aware secrets were required

@henrirosten
Copy link
Collaborator

@henrirosten I actually never saw this warning when testing, I was not aware secrets were required

It's strictly not required, but if there's no ssh_host_ed25519_key for the given nixosconfig, install task should issue a warning and ask confirmation from the user. If that's not what happens, then it's probably an error in tasks.py.

@joinemm
Copy link
Collaborator Author

joinemm commented Nov 23, 2023

added secrets and tested with install task

@henrirosten
Copy link
Collaborator

You are missing a license for the new secrets.yaml, you should add secrets.yaml.license similarly to other host configs:

WARNING 'reuse lint':
MISSING COPYRIGHT AND LICENSING INFORMATION

The following files have no copyright and licensing information:

  • hosts/monitoring/secrets.yaml

@joinemm joinemm merged commit 30ba7b4 into main Nov 23, 2023
1 check passed
@joinemm joinemm deleted the monitoring branch November 23, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants