Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine application processing #16

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Refine application processing #16

merged 1 commit into from
Sep 17, 2024

Conversation

mbssrc
Copy link
Collaborator

@mbssrc mbssrc commented Sep 17, 2024

Description

  • add application arguments to protobuffer
  • add automatic nix to JSON conversion for application definition
  • add argument processing to agent:
    • parsing application manifest
    • validate extra arguments
  • add extra (optional) arguments to givc-cli
  • add admin server args forwarding

Other:

  • remove obsolete application start function from go implementation
  • update nixpkgs
  • update go + deps

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Application manifest and requests tests added.
Tested on Ghaf.

@mbssrc mbssrc requested a review from avnik September 17, 2024 11:01
@mbssrc mbssrc force-pushed the app-args branch 2 times, most recently from 4813f5c to 626df89 Compare September 17, 2024 15:50
- add application arguments to protobuffer
- add automatic nix to JSON conversion for application definition
- add argument processing to agent:
- parsing application manifest
- validate extra arguments
- add extra (optional) arguments to givc-cli
- add admin server args forwarding
- remove obsolete application start function from go implementation
- update nixpkgs
- update go + deps

Signed-off-by: Manuel Bluhm <[email protected]>
@mbssrc mbssrc merged commit 3043389 into tiiuae:main Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant