Support multiple listeners #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slakkala
reviewed
Sep 2, 2024
| _request: tonic::Request<pb::systemd::UnitRequest>, | ||
| ) -> std::result::Result<tonic::Response<pb::systemd::UnitStatusResponse>, tonic::Status> { | ||
| _request: Request<pb::systemd::UnitRequest>, | ||
| ) -> Result<Response<pb::systemd::UnitStatusResponse>, Status> { |
There was a problem hiding this comment.
This is already much nicer; could also take it further by using tonic::Result to omit the Status, or even define our own type Result<T> = tonic::Result<Response<T>>.
avnik
force-pushed
the
avnik/listeners
branch
4 times, most recently
from
d27ef2c to
9fb6e65
Compare
Signed-off-by: Alexander V. Nikolaev <[email protected]>
Signed-off-by: Alexander V. Nikolaev <[email protected]>
Signed-off-by: Alexander V. Nikolaev <[email protected]>
Signed-off-by: Alexander V. Nikolaev <[email protected]>
Signed-off-by: Alexander V. Nikolaev <[email protected]>
Signed-off-by: Alexander V. Nikolaev <[email protected]>
avnik
force-pushed
the
avnik/listeners
branch
from
9fb6e65 to
c8a716f
Compare
Signed-off-by: Alexander V. Nikolaev <[email protected]>
avnik
force-pushed
the
avnik/listeners
branch
from
c8a716f to
d760e69
Compare
slakkala
approved these changes
Sep 25, 2024
| } | ||
|
|
||
| async fn connect_unix_socket(endpoint: Endpoint, path: &String) -> anyhow::Result<Channel> { | ||
| let mut path = Some(path.to_owned()); |
There was a problem hiding this comment.
Could use the Arc based solution here that we discussed earlier.
| Ok(ch) | ||
| } | ||
|
|
||
| async fn connect_vsock_socket(endpoint: Endpoint, vs: &VsockAddr) -> anyhow::Result<Channel> { |
There was a problem hiding this comment.
VsockAddr implements Copy, could just drop the reference and the let ....to_owned() (and use *vs in the caller)
| } | ||
| } | ||
|
|
||
| async fn connect_unix_socket(endpoint: Endpoint, path: &String) -> anyhow::Result<Channel> { |
| #[derive(Clone, Debug, PartialEq)] | ||
| pub enum EndpointAddress { | ||
| Tcp { | ||
| // IP + port (FIXME: should be SocketAddres) |
There was a problem hiding this comment.
Using String has the benefit of being able to use names instead of IP-addresses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support of multiple listeners -- UNIX domain socket, and also add possibility to add vsock support in future.
Also update tonic library to current release
Checklist
nix flake check --accept-flake-configand it passesTesting
TBD