-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing create service step for Felix metrics #1793
base: main
Are you sure you want to change the base?
Conversation
Removing create service step for Felix metrics as this step is automated through code.
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -272,24 +272,6 @@ For all Prometheus Felix configuration values, see [Felix Prometheus](../../../r | |||
|
|||
**Create a service to expose Felix metrics** | |||
|
|||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, for cloud this should be merged once they integrate v3.22.0-1.0, is that right? Because that is the first operator release that will have the changes for cloud users.
@ctauchen What is the best way to make sure we merge the diffs in this file later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rene-dekker Do you mean 3.21.0-1.0?
If that's the case, just leave it with me and I'll merge after I cut the new CC version on Monday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you for correcting me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I'm happy to remove this if it's no longer necessary. But we should make sure that the document still makes sense after.
It looks like most installations don't need this step, but you still need to do this if you have a hybrid cluster with Windows nodes.
If that's correct, we should change the title (line 273) to something like:
**For Windows nodes, create a service to expose Felix metrics**
If you're running $[prodnameWindows], you must create a service to expose Felix metrics for Windows nodes:
code
@@ -272,24 +272,6 @@ For all Prometheus Felix configuration values, see [Felix Prometheus](../../../r | |||
|
|||
**Create a service to expose Felix metrics** | |||
|
|||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rene-dekker Do you mean 3.21.0-1.0?
If that's the case, just leave it with me and I'll merge after I cut the new CC version on Monday.
Updated the content |
Removing create service step for Felix metrics as this step is automated through code.
Product Version(s):
Issue:
https://tigera.atlassian.net/browse/EV-5305
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: