Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing create service step for Felix metrics #1793

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vikastigera
Copy link
Contributor

Removing create service step for Felix metrics as this step is automated through code.

Product Version(s):

Issue:
https://tigera.atlassian.net/browse/EV-5305

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

Removing create service step for Felix metrics as this
step is automated through code.
@vikastigera vikastigera requested a review from a team as a code owner November 27, 2024 20:19
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 0980e36
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/674a104d3b5dc70008b6ec9e
😎 Deploy Preview https://deploy-preview-1793--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0980e36
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/674a104d00214d000834320e
😎 Deploy Preview https://deploy-preview-1793--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (🔴 down 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -272,24 +272,6 @@ For all Prometheus Felix configuration values, see [Felix Prometheus](../../../r

**Create a service to expose Felix metrics**

```bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, for cloud this should be merged once they integrate v3.22.0-1.0, is that right? Because that is the first operator release that will have the changes for cloud users.
@ctauchen What is the best way to make sure we merge the diffs in this file later?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rene-dekker Do you mean 3.21.0-1.0?

If that's the case, just leave it with me and I'll merge after I cut the new CC version on Monday.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you for correcting me.

Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I'm happy to remove this if it's no longer necessary. But we should make sure that the document still makes sense after.

It looks like most installations don't need this step, but you still need to do this if you have a hybrid cluster with Windows nodes.

If that's correct, we should change the title (line 273) to something like:

**For Windows nodes, create a service to expose Felix metrics**

If you're running $[prodnameWindows], you must create a service to expose Felix metrics for Windows nodes:

code

@@ -272,24 +272,6 @@ For all Prometheus Felix configuration values, see [Felix Prometheus](../../../r

**Create a service to expose Felix metrics**

```bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rene-dekker Do you mean 3.21.0-1.0?

If that's the case, just leave it with me and I'll merge after I cut the new CC version on Monday.

@vikastigera
Copy link
Contributor Author

Thanks for this. I'm happy to remove this if it's no longer necessary. But we should make sure that the document still makes sense after.

It looks like most installations don't need this step, but you still need to do this if you have a hybrid cluster with Windows nodes.

If that's correct, we should change the title (line 273) to something like:

**For Windows nodes, create a service to expose Felix metrics**

If you're running $[prodnameWindows], you must create a service to expose Felix metrics for Windows nodes:

code

Updated the content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants