Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_v2x_msgs): add TrafficLightInfo.msg #160

Open
wants to merge 1 commit into
base: tier4/universe
Choose a base branch
from
Open

feat(tier4_v2x_msgs): add TrafficLightInfo.msg #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tier4_v2x_msgs/msg/ExtraTrafficSignal.msg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
std_msgs/Header header
autoware_perception_msgs/TrafficLightGroup[] states
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this message is for describing the remaining time for traffic light state, it might be better to explicitly name the variable name as current_state or next_state since it is confusing for the users.

bool has_min_rest_time
float32 min_rest_time
float32 min_rest_time_to_red
bool has_max_rest_time
float32 max_rest_time
Comment on lines +3 to +7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What is the difference between min_rest_time and min_rest_time_to_red?
  • Why max_rest_time does not have max_rest_time_to_red?

Also, it sounds more natural if we name it remaning_time instead of rest_time.

5 changes: 5 additions & 0 deletions tier4_v2x_msgs/msg/TrafficLightInfo.msg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
std_msgs/Header header
unique_identifier_msgs/UUID vehicle_id
uint64 target_id
Comment on lines +2 to +3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these IDs for?

tier4_v2x_msgs/ExtraTrafficSignal[] car_lights
tier4_v2x_msgs/ExtraTrafficSignal[] pedestrian_lights
1 change: 1 addition & 0 deletions tier4_v2x_msgs/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

<build_depend>rosidl_default_generators</build_depend>

<depend>autoware_perception_msgs</depend>
<depend>builtin_interfaces</depend>
<depend>std_msgs</depend>

Expand Down
Loading