Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(awsim_sensor_kit_launch): awsim load concatenate node parameters #25

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Nov 7, 2024

Description

PR autowarefoundation/autoware.universe#8300 introduces a new concatenate algorithm and also removes the default parameter, thus the launcher would need to load the parameter from the parameter file.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@vividf vividf changed the title feat: awsim load comcatenate parameter feat(awsim_sensor_kit_launch): awsim load concatenate node parameters Nov 8, 2024
@vividf vividf marked this pull request as ready for review November 8, 2024 04:31
@vividf vividf self-assigned this Nov 8, 2024
@SakodaShintaro
Copy link
Contributor

Thank you. I will confirm e2e_simulator.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e_simulator works correctly.

I have a concern about changing the timeout_sec parameter from 0.01 to 0.2. While this change could affect the behavior of autoware_ekf_localizer, I haven't observed any issues on my machine. I would like to spend more time testing this change.

@vividf
Copy link
Contributor Author

vividf commented Nov 8, 2024

@SakodaShintaro

I see, I understand your concern.
I think you can test with the timeout sec: 0.05 or even lower in the simulation environment.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the correction.
LGTM

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vividf
I think a corresponding pull request is needed in https://github.com/autowarefoundation/autoware_individual_params.
For now, I will temporarily stop this pull request.
(Please tell me if I'm mistaken)

@vividf
Copy link
Contributor Author

vividf commented Dec 2, 2024

@SakodaShintaro
You are right :)
The parameters are moved in this PR autowarefoundation/autoware_individual_params#54.
Could you help test this PR with the individual PR together on the awsim :)
Thanks for your support!

Update!!!
This is not needed so I reverted the changes

@vividf vividf force-pushed the feature/tier4_awsim_load_concatenate branch from 2f2f4aa to 01f20e8 Compare December 3, 2024 02:56
@vividf
Copy link
Contributor Author

vividf commented Dec 3, 2024

@SakodaShintaro
Sorry that the changes are not necessary, so I reverted the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants