-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(awsim_sensor_kit_launch): awsim load concatenate node parameters #25
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
Thank you. I will confirm e2e_simulator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e_simulator
works correctly.
I have a concern about changing the timeout_sec
parameter from 0.01 to 0.2. While this change could affect the behavior of autoware_ekf_localizer
, I haven't observed any issues on my machine. I would like to spend more time testing this change.
awsim_sensor_kit_launch/config/concatenate_and_time_sync_node.param.yaml
Outdated
Show resolved
Hide resolved
I see, I understand your concern. |
awsim_sensor_kit_launch/config/concatenate_and_time_sync_node.param.yaml
Outdated
Show resolved
Hide resolved
awsim_sensor_kit_launch/config/concatenate_and_time_sync_node.param.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: vividf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the correction.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vividf
I think a corresponding pull request is needed in https://github.com/autowarefoundation/autoware_individual_params.
For now, I will temporarily stop this pull request.
(Please tell me if I'm mistaken)
@SakodaShintaro Update!!! |
2f2f4aa
to
01f20e8
Compare
@SakodaShintaro |
Description
PR autowarefoundation/autoware.universe#8300 introduces a new concatenate algorithm and also removes the default parameter, thus the launcher would need to load the parameter from the parameter file.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.