Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds one new public method
buntdb.(*DB).Sync
WAL Compaction
I'd like to use BuntDB with
SyncPolicy: Never
as an on-disk state machine behind a Raft proposal log. The raft log acts as a WAL and the raft library calls Sync explicitly on the state machine during WAL compaction.Without an explicit
Sync
operation in BuntDB, it's not possible to guarantee write durability. If the WAL is truncated and some updates have not yet been flushed to disk, a crash could cause unsynced writes to be discarded, causing the state machine to become unrecoverable.Similar To