Add a .bytes() method to HTTP responses #1095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new .bytes() method returns the body as bytes rather than a string. It is modeled after the .json() method, which parses the body as JSON. The use case is parsing HTTP requests that return binary data. Certain operations on strings in Starlark don't work correctly with binary (i.e., non-UTF-8 encoded) data. In particular, when strings contain non-UTF-8 binary data, the `ord` function returns 65533 (the codepoint for the Unicode replacement character) when called on a byte with a value between 0x80 and 0xff. `ord` functions as expected with bytes values.
benesch
added a commit
to benesch/tidbyt-nyc-subway-zoom
that referenced
this pull request
Nov 27, 2024
Since we're using a Protobuf API, pull the HTTP body as bytes rather than a string. This works around weird behavior in ord. Depends on tidbyt/pixlet#1095.
|
Here's the motivation for this in code (an app that parses the binary protobuf data in NYC subway feed directly): https://github.com/benesch/tidbyt-nyc-subway-zoom/pull/1/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new .bytes() method returns the body as bytes rather than a string. It is modeled after the .json() method, which parses the body as JSON.
The use case is parsing HTTP requests that return binary data. Certain operations on strings in Starlark don't work correctly with binary (i.e., non-UTF-8 encoded) data. In particular, when strings contain non-UTF-8 binary data, the
ordfunction returns 65533 (the codepoint for the Unicode replacement character) when called on a byte with a value between 0x80 and 0xff.ordfunctions as expected with bytes values.