Skip to content

Commit

Permalink
Disable some lint warnings. (#560)
Browse files Browse the repository at this point in the history
This commit disables lint warnings for unsorted dictionaries and naming
conventions. For dicts, the issue is there are a lot of dictionaries
that are logcially sorted in code and this would rewrite all of them.
For the naming, we have 2.8K naming convention violations in the
community repo so it would be really hard to enforce the other linters
if we didn't fix those first.
  • Loading branch information
betterengineering authored Jan 10, 2023
1 parent 5ec2fa5 commit 46e166a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cmd/buildifier.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,13 @@ var disabledWarnings = map[string]bool{
"function-docstring-header": true, // disables docstring warnings
"function-docstring-args": true, // disables docstring warnings
"function-docstring-return": true, // disables docstring warnings
"name-conventions": true, // disables naming convention warnings
"native-android": true, // disables native android rules
"native-cc": true, // disables native cc rules
"native-java": true, // disables native java rules
"native-proto": true, // disables native proto rules
"native-py": true, // disables native python rules
"unsorted-dict-items": true, // disables dictionary sorting
}

// processFile processes a single file containing data.
Expand Down

0 comments on commit 46e166a

Please sign in to comment.