fix(vue): fix generate type declaration #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tisqleditor-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
baurine
commented
Jul 25, 2024
| @@ -13,7 +13,7 @@ | |||
| "CHANGELOG.md" | |||
| ], | |||
| "scripts": { | |||
| "build": "vue-tsc -b && vite build" | |||
| "build": "vite build && vue-tsc -b" | |||
There was a problem hiding this comment.
vue-tsc -b generate type declaration in the dist folder, but vite build deletes the dist folder and re-create it, so we need to run vite build first, else we can't get the type declaration files.
baurine
commented
Jul 25, 2024
| @@ -1,9 +1,8 @@ | |||
| import { defineConfig } from 'vite' | |||
| import vue from '@vitejs/plugin-vue' | |||
| import dts from 'vite-plugin-dts' | |||
There was a problem hiding this comment.
because vue-tsc -b will get type declaration, so we don't need dts plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.