Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test for sql-parser/save-helper/core #24

Merged
merged 12 commits into from
Jun 27, 2024
Merged

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Jun 26, 2024

No description provided.

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for tisqleditor-playground ready!

Name Link
🔨 Latest commit 1d49a8d
🔍 Latest deploy log https://app.netlify.com/sites/tisqleditor-playground/deploys/667cd0d1a389530007d62f52
😎 Deploy Preview https://deploy-preview-24--tisqleditor-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@baurine baurine changed the title chore: add test for sql-parser chore: add test for sql-parser/save-helper/core Jun 27, 2024
@@ -0,0 +1,167 @@
import { EditorView } from '@codemirror/view'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the file name to a meaningful one

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this extension only has one file, I have no better idea, do you have any recommendation?

@@ -0,0 +1,95 @@
import { EditorView } from '@codemirror/view'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the file name to a meaningful one

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this extension only has one file, I have no better idea, do you have any recommendation?

@@ -37,6 +38,7 @@
"typescript": "^5.4.5"
},
"peerDependencies": {
"@codemirror/lang-sql": "^6.6.4",
Copy link
Collaborator Author

@baurine baurine Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the test, we need to install sql() extension from lang-sql package with sql-parser extension together, else sql-parser can't work.

@@ -0,0 +1,95 @@
import { EditorView } from '@codemirror/view'
import { EditorState } from '@codemirror/state'
import { MySQL, sql } from '@codemirror/lang-sql'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use lang-sql here, @sanshuiyijing

Copy link
Collaborator

@sanshuiyijing sanshuiyijing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@baurine baurine merged commit aa27f58 into main Jun 27, 2024
5 checks passed
@baurine baurine deleted the chore/add-test-case branch June 27, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants