-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add test for sql-parser/save-helper/core #24
Conversation
✅ Deploy Preview for tisqleditor-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0999205
to
bfc859f
Compare
e67727c
to
232e492
Compare
@@ -0,0 +1,167 @@ | |||
import { EditorView } from '@codemirror/view' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the file name to a meaningful one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this extension only has one file, I have no better idea, do you have any recommendation?
@@ -0,0 +1,95 @@ | |||
import { EditorView } from '@codemirror/view' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the file name to a meaningful one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this extension only has one file, I have no better idea, do you have any recommendation?
@@ -37,6 +38,7 @@ | |||
"typescript": "^5.4.5" | |||
}, | |||
"peerDependencies": { | |||
"@codemirror/lang-sql": "^6.6.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the test, we need to install sql()
extension from lang-sql
package with sql-parser
extension together, else sql-parser
can't work.
@@ -0,0 +1,95 @@ | |||
import { EditorView } from '@codemirror/view' | |||
import { EditorState } from '@codemirror/state' | |||
import { MySQL, sql } from '@codemirror/lang-sql' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use lang-sql
here, @sanshuiyijing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.