Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extension readme #21

Merged
merged 2 commits into from
Jun 25, 2024
Merged

feat: extension readme #21

merged 2 commits into from
Jun 25, 2024

Conversation

sanshuiyijing
Copy link
Collaborator

No description provided.

@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

✅ Deploy Preview for tisqleditor-playground ready!

Name Link
🔨 Latest commit 14b6bc4
🔍 Latest deploy log https://app.netlify.com/sites/tisqleditor-playground/deploys/667a9916982c9e00087e6aad
😎 Deploy Preview https://deploy-preview-21--tisqleditor-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

baurine
baurine reviewed Jun 25, 2024
View reviewed changes
packages/extensions/events/README.md Outdated
You need to install its peer dependencies as well:

```shell
npm install @codemirror/view @codemirror/view
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codemirror/view -> @codemirror/state

baurine
baurine requested changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave some comments, the rest LGTM

@sanshuiyijing sanshuiyijing merged commit 7c4fc55 into main Jun 25, 2024
5 checks passed
@sanshuiyijing sanshuiyijing deleted the feat/docs branch June 25, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baurine baurine baurine approved these changes

Assignees
No one assigned
Labels
no-ct task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanshuiyijing @baurine