Fix cluster resource status inconsistent #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiyuhang0
force-pushed
the
fix_inconsistence
branch
from
ac00713 to
fe32b14
Compare
zhangyangyu
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #107
What is changed and how it works?
In this PR #106 we add
UseStateForUnknownforcluster_status. However, this causes the #107.Actually,
UseStateForUnknownis for the attribute that will not be changed after the update.cluster_statusis not suitable for it. The root cause of #106 lies in hashicorp/terraform-plugin-framework#669. What we should do for #106 is upgrade terraform-plugin-framework rather than addUseStateForUnknown.This PR removes
UseStateForUnknownforcluster_statuswhich was wrong introduced in #106, and upgrade the version of terraform-plugin-framework. This should fix #107 and #105.This PR also upgrade:
Check List
go generateif you modifyexamples.