Skip to content

Commit

Permalink
E_showMenu_Q3: remove scroller as cb func argument
Browse files Browse the repository at this point in the history
This removes a potential for memory leaks and should otherwise have no
impact. As no app on the main BangleApps repo seems to use the option.
See espruino#2567.
  • Loading branch information
thyttan committed Oct 10, 2024
1 parent 133933b commit 6d900fb
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion libs/js/banglejs/E_showMenu_Q3.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
if (idx<0) return back&&back(); // title
var item = menu[keys[idx]];
Bangle.buzz(20);
if ("function" == typeof item) item(l);
if ("function" == typeof item) item();
else if ("object" == typeof item) {
// if a bool, just toggle it
if ("number" == typeof item.value) {
Expand Down
14 changes: 7 additions & 7 deletions libs/js/banglejs/E_showMenu_Q3.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6d900fb

Please sign in to comment.