-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add resvg-js
CLI to @resvg/resvg-js
#349
base: main
Are you sure you want to change the base?
Conversation
avoid file buffer being interrupted
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I sincerely appreciate your contribution to the resvg-js ecosystem, but since this is a rust-oriented project, I'd like the CLI to be in a separate repository. I can add you to the |
Thanks !!! and how do I publish to @resvg org or add @resvg team? |
#348
I'm glad you can let me feel free do this work.
After some consideration, I think it would be more straightforward to directly include the CLI bundle file in the @resvg/resvg-js project and add a bin file. This way, CLI can directly use the core functions in ./index.js with the transform options:
yarn resvg-js
orpnpm resvg-js
.I would like to hear your opinion. If you have any other ideas, feel free to tell me.
monorepo or create a new repo. IMO, placing it in the project as a separate file that can be called will not impact the main program's operation, and it will maintain uniformity in future maintenance and version control.
Next plan:
js
orts
(I would like to hear your opinion. Initially, I found that index.js was written in JavaScript, but later the wasm was written in TypeScript.🫣)cli/option.js
. ensure CLI options can be transformResvgOptions
I released a pre-release version for testing, welcome to experience it
bunx @qbbsh/resvg-js -h # or npx @qbbsh/resvg-js -h
Base usage
base-usage.mp4
Advanced Usage
pipeline
with-imagemagick.mp4