Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): missing .node file for x86_64-apple-darwin #320

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

yisibl
Copy link
Member

@yisibl yisibl commented Mar 25, 2024

We need to set a default target for macos-14 when you build, otherwise, x86_64-apple-darwin will be packaged as an arm64 file, and the npm release will fail due to the lack of x86_64 files.

Problems introduced here: 0cae91e

Closed: #319

See log: https://github.com/yisibl/resvg-js/actions/runs/8419314291/job/23051987833

image

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
resvg-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 4:22pm

@yisibl yisibl force-pushed the fix-build-mac-x86_64 branch from 76af3df to b2d7d5b Compare March 25, 2024 16:22
@yisibl yisibl merged commit 60942db into main Mar 25, 2024
37 checks passed
@yisibl yisibl deleted the fix-build-mac-x86_64 branch March 25, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couldn't find any versions for "@resvg/resvg-js-darwin-x64" that matches "2.6.1"
1 participant