Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop testing drupal 9 #78

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Stop testing drupal 9 #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43beacd
Stop testing drupal 9
ol0lll Feb 19, 2024
447a626
try 10.1
ol0lll Feb 19, 2024
d313472
test 10.2
ol0lll Feb 20, 2024
65ca3fa
remove t() calls from tests
ol0lll Feb 20, 2024
29d53b4
fix another
ol0lll Feb 20, 2024
9245e38
fix claro
ol0lll Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
strategy:
matrix:
THEME: ['claro', 'gin']
DRUPAL_TESTING_DRUPAL_VERSION: ['~9.5.0', '~10.1.0']
DRUPAL_TESTING_DRUPAL_VERSION: ['~10.1.0', '~10.2.0']
PHP_VERSION: ['8.1']

steps:
Expand Down
2 changes: 1 addition & 1 deletion tests/src/FunctionalJavascript/ParagraphsFeatureCollapseAllTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function testCollapseAllOption() {
$page->uncheckField('fields[field_paragraphs][settings_edit_form][third_party_settings][paragraphs_features][show_collapse_all]');
$this->submitForm([], 'Update');
$this->assertSession()->assertWaitOnAjaxRequest();
$this->submitForm([], $this->t('Save'));
$this->submitForm([], 'Save');

// Check that Edit all button is and Collapse all button is not present.
$this->drupalGet("node/add/$content_type");
Expand Down
11 changes: 4 additions & 7 deletions tests/src/FunctionalJavascript/ParagraphsFeaturesAddInBetweenTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public function testAddInBetweenFeature() {
$session = $this->getSession();
$page = $session->getPage();
$driver = $session->getDriver();

$page->pressButton('field_paragraphs_settings_edit');
$this->assertSession()->assertWaitOnAjaxRequest();

Expand Down Expand Up @@ -66,7 +65,7 @@ public function testAddInBetweenFeature() {

$this->submitForm([], 'Update');
$this->assertSession()->assertWaitOnAjaxRequest();
$this->submitForm([], $this->t('Save'));
$this->submitForm([], 'Save');

// Check that default add mode functionality is used.
$this->drupalGet("node/add/$content_type");
Expand All @@ -83,7 +82,7 @@ public function testAddInBetweenFeature() {

$this->submitForm([], 'Update');
$this->assertSession()->assertWaitOnAjaxRequest();
$this->submitForm([], $this->t('Save'));
$this->submitForm([], 'Save');

// Check that add in between functionality is used.
$this->drupalGet("node/add/$content_type");
Expand All @@ -93,7 +92,6 @@ public function testAddInBetweenFeature() {
// Add a nested paragraph and check that add in between is used only for
// base paragraphs field, but not for the nested paragraph.
$session->executeScript("document.querySelector('.paragraphs-features__add-in-between__button').click()");
$this->assertSession()->assertWaitOnAjaxRequest();
$page->find('xpath', '//*[contains(@class, "paragraphs-add-dialog") and contains(@class, "ui-dialog-content")]//*[contains(@name, "test_nested")]')->click();
$this->assertSession()->assertWaitOnAjaxRequest();

Expand Down Expand Up @@ -145,7 +143,7 @@ public function testAddInBetweenFeature() {
$page->uncheckField('fields[field_paragraphs][settings_edit_form][third_party_settings][paragraphs_features][add_in_between]');
$this->submitForm([], 'Update');
$this->assertSession()->assertWaitOnAjaxRequest();
$this->submitForm([], $this->t('Save'));
$this->submitForm([], 'Save');

// Set modal add mode with add in between option for nested paragraph.
$this->drupalGet("admin/structure/paragraphs_type/test_nested/form-display");
Expand All @@ -158,14 +156,13 @@ public function testAddInBetweenFeature() {
$page->fillField('fields[field_paragraphs][settings_edit_form][third_party_settings][paragraphs_features][add_in_between_link_count]', '0');
$this->submitForm([], 'Update');
$this->assertSession()->assertWaitOnAjaxRequest();
$this->submitForm([], $this->t('Save'));
$this->submitForm([], 'Save');

// Check that add in between functionality is not available for base
// paragraphs and it's used for nested paragraph.
$this->drupalGet("node/add/$content_type");

$session->executeScript("document.querySelector('.paragraph-type-add-modal-button').click()");
$this->assertSession()->assertWaitOnAjaxRequest();
$page->find('xpath', '//*[contains(@class, "paragraphs-add-dialog") and contains(@class, "ui-dialog-content")]//*[contains(@name, "test_nested")]')->click();
$this->assertSession()->assertWaitOnAjaxRequest();

Expand Down
2 changes: 1 addition & 1 deletion tests/src/FunctionalJavascript/ParagraphsFeaturesDeleteConfirmationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ protected function toggleDeleteConfirmation($content_type, $op = 'check') {
$page->$action('fields[field_paragraphs][settings_edit_form][third_party_settings][paragraphs_features][delete_confirmation]');
$this->submitForm([], 'Update');
$this->assertSession()->assertWaitOnAjaxRequest();
$this->submitForm([], $this->t('Save'));
$this->submitForm([], 'Save');
}

}
3 changes: 1 addition & 2 deletions tests/src/FunctionalJavascript/ParagraphsFeaturesExtendedParagraphsWidgetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public function testAddInBetweenFeature() {
$this->submitForm([], 'Update');
$this->assertSession()->assertWaitOnAjaxRequest();

$this->submitForm([], $this->t('Save'));
$this->submitForm([], 'Save');

// Check that add in between functionality is used.
$this->drupalGet("node/add/$content_type");
Expand All @@ -60,7 +60,6 @@ public function testAddInBetweenFeature() {
// Add a nested paragraph and check that add in between is used only for
// base paragraphs field, but not for the nested paragraph.
$session->executeScript("document.querySelector('.paragraphs-features__add-in-between__button').click()");
$this->assertSession()->assertWaitOnAjaxRequest();
$page->find('xpath', '//*[contains(@class, "paragraphs-add-dialog") and contains(@class, "ui-dialog-content")]//*[contains(@name, "test_nested")]')->click();
$this->assertSession()->assertWaitOnAjaxRequest();

Expand Down
Loading