Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3324781: Add split text functionality to CKEditor 5 #76

Closed
wants to merge 11 commits into from
Closed

Issue #3324781: Add split text functionality to CKEditor 5 #76

wants to merge 11 commits into from

Conversation

zibellino
Copy link

@zibellino zibellino commented Oct 25, 2023

Implementation of the split text (split paragraph) functionality for CKEditor5.
Based on the ckeditor5_plugin_starter_template, and as such has the same dependencies.

Uses a custom split function instead of SplitOperation, and the "Add in-between" button instead of it's own modal.

https://www.drupal.org/project/paragraphs_features/issues/3400542

Copy link

@milkovsky milkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code both looks and works good! There are 2 minor comments.

paragraphs_features.ckeditor5.yml Outdated Show resolved Hide resolved
paragraphs_features.libraries.yml Outdated Show resolved Hide resolved
@milkovsky
Copy link

Also please create a d.o. issue for this feature.

@zibellino zibellino requested a review from milkovsky November 9, 2023 15:22
Copy link

@milkovsky milkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks and works good!

milkovsky

This comment was marked as duplicate.

@zibellino zibellino requested a review from milkovsky November 16, 2023 14:11
@ol0lll
Copy link
Member

ol0lll commented Apr 5, 2024

Closing in favour of #80

@ol0lll ol0lll closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants