Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

23 add window buttons and title #80

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

23 add window buttons and title #80

wants to merge 8 commits into from

Conversation

kirontoo
Copy link

@kirontoo kirontoo commented Oct 5, 2023

No description provided.

@vercel
Copy link

vercel bot commented Oct 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
terminal-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 9:05pm

@thtauhid
Copy link
Owner

thtauhid commented Oct 6, 2023

Hi @kirontoo
Can you add the same feature in the Profile page also?

@kirontoo
Copy link
Author

kirontoo commented Oct 6, 2023

can do!

@thtauhid
Copy link
Owner

thtauhid commented Oct 6, 2023

can do!

Please do so.
Also, don't forget to merge the main branch into your dev branch to resolve any conflicts.

@thtauhid
Copy link
Owner

thtauhid commented Oct 6, 2023

Build log:
image

@thtauhid
Copy link
Owner

thtauhid commented Oct 6, 2023

@kirontoo

The X button should be in the middle.
image
Can you also take care of this?

@thtauhid thtauhid linked an issue Oct 6, 2023 that may be closed by this pull request
Add window buttons and title #23
Open
@kirontoo
Copy link
Author

kirontoo commented Oct 6, 2023

image

Is this better?

@thtauhid
Copy link
Owner

thtauhid commented Oct 6, 2023

image

Is this better?

perfect

@thtauhid thtauhid added hacktoberfest-accepted PR is accepted under hacktoberfest needs testing and removed change requested hacktoberfest-accepted PR is accepted under hacktoberfest labels Oct 6, 2023
@thtauhid
Copy link
Owner

thtauhid commented Oct 6, 2023

For some reason, it's showing like this on my device.
image

I'll check in few other devices and post update.

@thtauhid
Copy link
Owner

Hi @kirontoo
It shows the same.
image

@kirontoo
Copy link
Author

that's weird. Maybe I should use icons instead of the HTML unicode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add window buttons and title
2 participants
@kirontoo @thtauhid