Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds stable-zero123 guidance #356

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Adds stable-zero123 guidance #356

merged 8 commits into from
Dec 13, 2023

Conversation

voletiv
Copy link
Collaborator

@voletiv voletiv commented Dec 11, 2023

Adds guidance for Stable-Zero123 model. Doesn't affect anything else!

Final_video_v01

@voletiv voletiv changed the title Adds stable-zero123 guidance [DRAFT] Adds stable-zero123 guidance Dec 11, 2023
@voletiv voletiv requested review from claforte and aletts and removed request for claforte December 12, 2023 01:14
@bennyguo
Copy link
Collaborator

Looks good to me (although can't be tested). @DSaurus

@DSaurus
Copy link
Collaborator

DSaurus commented Dec 12, 2023

Looks good to me. I've also made modifications to the config and misc code for more general use cases. Please review it before merging. @voletiv

@DSaurus DSaurus self-requested a review December 12, 2023 14:57
DSaurus
DSaurus previously approved these changes Dec 12, 2023
@voletiv
Copy link
Collaborator Author

voletiv commented Dec 12, 2023

@DSaurus Done! Lgtm :)

@voletiv voletiv removed the request for review from aletts December 12, 2023 14:58
@voletiv
Copy link
Collaborator Author

voletiv commented Dec 12, 2023

@DSaurus @bennyguo I changed the link to the HF repo, please review again :)

@voletiv voletiv requested a review from aletts December 12, 2023 16:04
Copy link
Collaborator

@DSaurus DSaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, lgtm!

@voletiv voletiv changed the title [DRAFT] Adds stable-zero123 guidance Adds stable-zero123 guidance Dec 12, 2023
@voletiv voletiv merged commit 56564c8 into main Dec 13, 2023
2 checks passed
@voletiv voletiv deleted the vikram/SAI_RELEASE1 branch December 13, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants