Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use lookbook which relies on htmlbeautifier to output pretty HTML and we have some custom block elements (such as
<turbo-frame>
) which are not rendered indented.This PR replace the constants from
HtmlBeautifier::HtmlParser
by methods which allows to specify additional elements:The downside is that mappings is compiled each time HtmlParser is initialized.
If this is an issue, I guess I can add a method to compile and cache the mappings only once.
I've add tests in a second commit but: