Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent with javascript tag #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michaelglass
Copy link

@michaelglass michaelglass commented Oct 5, 2022

allows <%= javascript_tag %>...<%end> to behave like <script>...</script>

I haven't read enough of the whole library to understand the consequences of this PR! It wouldn't surprise me if it is very broken!

Consider this as much a "feature request / issue" as a PR.

... But was easy enough to hack it together so made a PR.

Thanks for your wonderful, relatively lightweight gem.

@threedaymonk
Copy link
Owner

Sorry I've neglected this for so long! I think the goal is good here, but instead of treating javascript_tag specially, it should probably indent anything within a Ruby do/end block.

I'll leave this PR open as a reminder (and because I'll take the tests).

@ziadsawalha
Copy link

This also needs to ignore tags within tags. Ex

<%= javascript_tag nonce: true do %>
  fetch('<%= root_url %>/cart.json', ...);
<% end %>

gets reformatted to

<%= javascript_tag nonce: true do %>
  fetch('<%= root_url %>
  /cart.json', ...);
<% end %>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants