Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#416 Fix - Files of the same name in sub-folders will be considered a… #455

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

deepthirera
Copy link
Collaborator

@deepthirera deepthirera commented May 21, 2024

This PR fixes #416
Issue happens when the repo has multiple files of the same name in different directories.
This is because in various scenarios, a function in gitrepo.go checks if a file matches a pattern

`func (a Addition) Matches(pattern string) bool {
	var result bool
	if pattern[len(pattern)-1] == '/' {
		result = strings.HasPrefix(string(a.Path), pattern)
	} else if strings.ContainsRune(pattern, '/') {
		result, _ = path.Match(pattern, string(a.Path))
	} else {
		result, _ = path.Match(pattern, string(a.Name))
	}
`

The last condition matches against the file name a.Name and hence it considers both "readme.md" and "sub-folder/readme.md" as the same. Both these files are considered the same, but the checksum are different.

So, even if a readme.md is already ignored in .talismanrc, the checksum doesnt match with the file in sub-folder. Hence talisman suggests the same suggestion that is already in talismanrc.

With this fix, in addition to the existing pattern matches, we have a new match that does a string compare of the filepath and the given pattern as the final default. With this, all these patterns are allowed. sub-folder/, sub-folder/*, *.txt, sub-folder/readme.md, readme.md(this one alone is matched exactly with the file name).

@tinamthomas tinamthomas self-assigned this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially invalid checksum in githook report
2 participants