#416 Fix - Files of the same name in sub-folders will be considered a… #455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #416
Issue happens when the repo has multiple files of the same name in different directories.
This is because in various scenarios, a function in gitrepo.go checks if a file matches a pattern
The last condition matches against the file name
a.Name
and hence it considers both "readme.md" and "sub-folder/readme.md" as the same. Both these files are considered the same, but the checksum are different.So, even if a readme.md is already ignored in .talismanrc, the checksum doesnt match with the file in sub-folder. Hence talisman suggests the same suggestion that is already in talismanrc.
With this fix, in addition to the existing pattern matches, we have a new match that does a string compare of the filepath and the given pattern as the final default. With this, all these patterns are allowed. sub-folder/, sub-folder/*, *.txt, sub-folder/readme.md, readme.md(this one alone is matched exactly with the file name).