Added Swift version of the code for better readability and just for the fun of it. #11
Conversation
…e, also fixed a couple of other minor bugs with color and details (waste two hours on that stupid opposite condition bug)
…ems, changed csv reader from ASCII to UTF8
…r all parts of the world
| @@ -43,7 +43,7 @@ class ViewController: UIViewController, MKMapViewDelegate { | |||
| let toRemove = NSMutableSet(set: before) | |||
| toRemove.minusSet(after as Set<NSObject>) | |||
|
|
|||
| dispatch_async(dispatch_get_main_queue()) { () -> Void in | |||
| NSOperationQueue().addOperationWithBlock() { | |||
There was a problem hiding this comment.
You are creating a new NSOperationQueue and modifying the mapView while running on that new queue. The mapView, like all UIViews, should only be modified on the main queue/thread.
There was a problem hiding this comment.
Wouldn't the potential problem you're describing cause the app to crash if the code was actually changing the view from another thread? am I'm missing something?
There was a problem hiding this comment.
I've seen several occasions where views where modified on a background thread and it did not lead to a crash. It usually results in weird behavior.
There was a problem hiding this comment.
Oh wait, it seems that I actually fixed this bug on the next commit:
be4bdcd
There was a problem hiding this comment.
I'm sorry, you are right.
However, NSOperationQueue.mainQueue().addOperationWithBlock() is essentially the same as dispatch_async(dispatch_get_main_queue()). I personally prefer dispatch queues and in Swift 3 libdispatch got a really nice "swifty" interface, see https://github.com/apple/swift-evolution/blob/master/proposals/0088-libdispatch-for-swift3.md
There was a problem hiding this comment.
Good to know :), I'm still learning Swift - that was part of the reason I decided to translate the code - it helped me understand the clustering algorithm better and try out coding in Swift.
Also I find Objective-C's syntax repulsive :P
Hey,
I stumbled upon your code while learning Swift and looking for clustering abilities,
In order to better understand your solution I migrated your code to a Swift solution.
As it is already implemented I thought others like me(people with no knowledge of the Objective-C language nor willing to learn it) might appreciate the ability to read the same code in the Swift language.