Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relayproxy): Remove Timeout middleware #2864

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Dec 24, 2024

Description

The Timeout middleware is bringing more problems than it solves (see #2758), since as the maintainer of echo are saying this is better not to use it rather trying to solve all the issues it brings.

sigh I really dislike this middleware because it so complex and has so many hidden "features" and I'm too dumb to fix all those problems in a reasonable way.

I have decided to stop trying to manage a server timeout, this gonna be the client responsibility to handle it (and we will handle it in the different OpenFeature providers).

Note

This breaking change is minimal, if you continue to use the property restApiTimeout in your configuration file, it will be ignored.

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 4a78f0e
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/676af0d4604ca50008f08630

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (5a6108d) to head (4a78f0e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2864      +/-   ##
==========================================
+ Coverage   84.77%   84.79%   +0.02%     
==========================================
  Files         111      111              
  Lines        5207     5195      -12     
==========================================
- Hits         4414     4405       -9     
+ Misses        628      625       -3     
  Partials      165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant marked this pull request as ready for review December 24, 2024 17:40
@thomaspoignant thomaspoignant merged commit 7d94c06 into main Dec 24, 2024
25 checks passed
@thomaspoignant thomaspoignant deleted the fix-remove-timeout-middleware branch December 24, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant