Add ESM Support #20
Open
Add ESM Support #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
format: "esm", with esbuild, this plugin will produce runtime errors because TypeScript will transpile the module to CommonJS. You'll even get a warning from esbuild:The canonical way to get TypeScript to treat input files as ESM is to use the
.mtsfile extension. However, this plugin will filter those files and they won't be compiled by typescript. To fix this I updated the filter regex to allow.mtsand.mtsx.In addition, a lot of folks likely do not use the
.mtsextension and renaming the files of a large project would likely be tedious so I added an option to force TypeScript to treat the files as ESM.