The animation image will be hide during IDMPhotoBrowser is launching #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When launching the IDMPhotoBrowser, the animation process is hide when the IDMPhotoBrowser is launching, which will give user a feel that the image is moving to the target position, then disappear for a while, and finally show the actual image. This fix will make sure the IDMPhotoBrowser is transparent before the animation is down, which makes the animation very smooth.
… we can have the close animation once user has navigated to other image
…007/IDMPhotoBrowser into smooth-launch-animation # Conflicts: # Classes/IDMPhotoBrowser.m
…n be shown in a post
…e view as already been dismissed
…the image's original size
…aunch-animation * commit '83ba41f2a1ab8a10da98da916887d0825796fcc6': (29 commits) Bump version enable customize action button image Fix SDWebImage dependency Update SDWebImage method name Use actual interface orientation instead of the device one to fix misplaced progress view when orientations do not match Update .podspec Bump version Bump version Update README.markdown Demo project in Swift New action customization: dismiss browser on touch modify zoomToRect logic and criteria of zoom in or out. Project settings create maximumDoubleTapZoomScale for determine scale of double tap zoom Bump version Use cookies when downloading images Add Dutch localization Add japanese localization Added option to retina hd Increase the size of the button if a size if inferior to 44.0 ... # Conflicts: # Classes/IDMPhoto.m # Classes/IDMPhotoBrowser.h # Classes/IDMPhotoBrowser.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching the IDMPhotoBrowser, the animation process is hide when the IDMPhotoBrowser is launching, which will give user a feel that the image is moving to the target position, then disappear for a while, and finally show the actual image.
This fix will make sure the IDMPhotoBrowser is transparent before the animation is down, which makes the animation very smooth.
This change is