Remove app id from iac

thewca · Jul 17, 2024 · 1320eec · 1320eec
1 parent d519be7
commit 1320eec
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 12 deletions.
diff --git a/client/.env b/client/.env
@@ -1,5 +1,5 @@
-# VITE_API_URL=http://localhost:8080
-VITE_API_URL=https://statistics-api.worldcubeassociation.org
+VITE_API_URL=http://localhost:8080
+# VITE_API_URL=https://statistics-api.worldcubeassociation.org
 VITE_APP_VERSION=local
 VITE_APP_DATE_VERSION=today
 VITE_APP_WCA_BASE_URL=https://www.worldcubeassociation.org

diff --git a/iac/README.md b/iac/README.md
@@ -41,7 +41,6 @@ export read_password="ANOTHER_STRONG_PASSWORD_HERE"
 ```
 
 ```bash
-aws ssm put-parameter --name "/config/$environment/statistics/app/id"                   --value $app_id          --overwrite --region $region --type String
 aws ssm put-parameter --name "/config/$environment/statistics/dumped_db/write_user"     --value $write_user      --overwrite --region $region --type String
 aws ssm put-parameter --name "/config/$environment/statistics/dumped_db/write_password" --value $write_password  --overwrite --region $region --type String
 aws ssm put-parameter --name "/config/$environment/statistics/dumped_db/read_user"      --value $read_user       --overwrite --region $region --type String

diff --git a/iac/data-ssm.tf b/iac/data-ssm.tf
@@ -1,7 +1,3 @@
-data "aws_ssm_parameter" "statistics_app_id" {
-  name = "/config/${terraform.workspace}/statistics/app/id"
-}
-
 data "aws_ssm_parameter" "dumped_db_write_user" {
   name = "/config/${terraform.workspace}/statistics/dumped_db/write_user"
 }

diff --git a/iac/ecs.tf b/iac/ecs.tf
@@ -24,7 +24,6 @@ resource "aws_ecs_task_definition" "statistics_server_task_definition" {
     fargate_memory = var.statistics_fargate_memory
     aws_region     = var.aws_region
     spring_profile = terraform.workspace
-    app_id         = data.aws_ssm_parameter.statistics_app_id.value
     db_port        = var.default_mysql_port
     db_host        = aws_db_instance.dumped_db.address
     db_name        = var.dumped_db_name

diff --git a/iac/templates/ecs/statistics_server_app.json.tpl b/iac/templates/ecs/statistics_server_app.json.tpl
@@ -20,10 +20,6 @@
       }
     ],
     "environment": [
-      {
-        "name": "APP_ID",
-        "value": "${app_id}"
-      },
       {
         "name": "DB_USERNAME",
         "value": "${db_username}"