Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a few more options and ordered users by date of last post #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

keithws
Copy link

@keithws keithws commented Jul 13, 2018

I really like this plugin, so I added a few features.

  • Order contributors by date of last post in reverse-cronological order
  • Add option to show/hide the contributor’s avatar
  • Add option to show/hide the contributor’s name
  • Add option to blacklist users from the recent contributors list by user id
  • Update call to get users to filter out subscribers and limit the fields returned to only those needed

Let me know if you'd like to pull this in or if you'd like me to change some stuff.

@keithws
Copy link
Author

keithws commented Jul 13, 2018

I noticed a bug showing all users' post counts as zero and I fixed it. I also added title attribute to better describe the links (based on link destination.)

@theukedge
Copy link
Owner

theukedge commented Jul 13, 2018 via email

@theukedge
Copy link
Owner

@keithws Keith, thanks for your contribution. It'll take me a little while to get to this, but I definitely plan to merge this in. Cheers for taking the time to do this.

@keithws
Copy link
Author

keithws commented Jul 18, 2018

Thank you for the response. I tried to follow your coding style and I tried to not to change too much. You'll see in the diff that it's mostly adds for the new features, but I did end up with many changes to the block of code that actually renders the HTML to display the widget. I like what I ended up with, but I'm open to debate on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants