Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace Bundle Integration tests #1588

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Marketplace Bundle Integration tests #1588

merged 2 commits into from
Dec 3, 2024

Conversation

capedcrusader21
Copy link
Contributor

@capedcrusader21 capedcrusader21 commented Sep 9, 2024 •
edited
Loading

Description

  • restructure integration_test in deploy package
  • added integration test to execute bundle exchange using matchOrders() with primary market seller

@capedcrusader21 capedcrusader21 force-pushed the test/marketplace-integration-tests branch from 52ee1c7 to c56f4da Compare October 18, 2024 08:37
@capedcrusader21 capedcrusader21 changed the base branch from feat/marketplace-bundle-type to marketplace-bundle/N-06-gas-optimization October 18, 2024 08:37
@capedcrusader21 capedcrusader21 marked this pull request as ready for review October 18, 2024 08:38
@capedcrusader21 capedcrusader21 requested a review from a team as a code owner October 18, 2024 08:38
@capedcrusader21 capedcrusader21 requested review from atkinsonholly and removed request for a team October 18, 2024 08:38
@capedcrusader21 capedcrusader21 changed the title Marketplace Integration tests Marketplace Bundle Integration tests Oct 18, 2024
@openzeppelin-code OpenZeppelin Code
Copy link

Marketplace Integration tests

Generated at commit: c56f4dae860c3a8aa850f1874994c3969c67339a

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
1
0
5
30
39

For more details view the full report in OpenZeppelin Code Inspector

Base automatically changed from marketplace-bundle/N-06-gas-optimization to marketplace-bundle/N-05-lack-of-security-contract December 3, 2024 10:23
@wojciech-turek wojciech-turek merged commit c552bec into marketplace-bundle/N-05-lack-of-security-contract Dec 3, 2024
6 checks passed
@wojciech-turek wojciech-turek deleted the test/marketplace-integration-tests branch December 3, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciech-turek wojciech-turek Awaiting requested review from wojciech-turek

@atkinsonholly atkinsonholly Awaiting requested review from atkinsonholly atkinsonholly was automatically assigned from thesandboxgame/blockchain-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capedcrusader21 @wojciech-turek