Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added network tag and enum #1558

Closed
wants to merge 1 commit into from
Closed

feat: added network tag and enum #1558

wants to merge 1 commit into from

Conversation

capedcrusader21
Copy link
Contributor

Description

  • added network enums and tags

@capedcrusader21 capedcrusader21 requested a review from a team as a code owner July 15, 2024 12:42
@capedcrusader21 capedcrusader21 requested review from atkinsonholly and adjisb and removed request for a team July 15, 2024 12:42
wojciech-turek
wojciech-turek requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@wojciech-turek wojciech-turek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR breaks a lot of deployment scripts, we can't do it like that.

@capedcrusader21 capedcrusader21 deleted the feat/lz-sand-deployments-network-enum-and-tag branch July 15, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciech-turek wojciech-turek wojciech-turek requested changes

@atkinsonholly atkinsonholly Awaiting requested review from atkinsonholly atkinsonholly is a code owner automatically assigned from thesandboxgame/blockchain-reviewers

@adjisb adjisb Awaiting requested review from adjisb adjisb is a code owner automatically assigned from thesandboxgame/blockchain-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capedcrusader21 @wojciech-turek