Small changes to merge after the audit #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjisb
requested review from
atkinsonholly and
wojciech-turek
and removed request for
a team
adjisb
force-pushed
the
feat/land-refactor-post-audit-fixed
branch
from
3675867 to
4d9654b
Compare
atkinsonholly
approved these changes
Jun 27, 2024
- Add a few interfaces related to quad operations and metadata registry to suppportInteface - Make UNKNOWN_NEIGHBORHOOD constant private in the land contract so it is not exposed in the abi. - This PR include some minor changes that we are fixing in advance as a result of some comments from the auditors. If needed they will be split in separated PRs before merging this one.
adjisb
force-pushed
the
feat/land-refactor-post-audit-fixed
branch
from
4d9654b to
59bd3de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
suppportIntefaceUNKNOWN_NEIGHBORHOODconstant private in the land contract so it is not exposed in the abi.