Marketplace max coverage #1206
Merged
Marketplace max coverage #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capedcrusader21
changed the title
capedcrusader21
force-pushed
the
test/marketplace-max-coverage
branch
from
e0c8732 to
bc03f87
Compare
mvanmeerbeck
reviewed
Oct 9, 2023
mvanmeerbeck
reviewed
Oct 9, 2023
mvanmeerbeck
suggested changes
Oct 9, 2023
mvanmeerbeck
approved these changes
Oct 9, 2023
adjisb
approved these changes
Oct 9, 2023
| @@ -32,6 +36,7 @@ contract TestERC1155WithRoyaltyV2981 is | |||
| ) public view virtual override(ERC1155Upgradeable, Royalties2981TestImpl) returns (bool) { | |||
| return | |||
| interfaceId == LibRoyalties2981._INTERFACE_ID_ROYALTIES || | |||
| interfaceId == INTERFACE_ID_GET_RECIPIENTS || | |||
There was a problem hiding this comment.
can we do it like: type(IMultiRoyaltyRecipients).interfaceId ?
| @@ -191,15 +190,8 @@ abstract contract TransferManager is ERC165Upgradeable, ITransferManager { | |||
| /// @param nftAssetType NFT Asset Type to calculate royalties for | |||
| /// @return calculated royalties (Array of LibPart.Part) | |||
| function _getRoyaltiesByAssetType(LibAsset.AssetType memory nftAssetType) internal returns (LibPart.Part[] memory) { | |||
There was a problem hiding this comment.
This method will work for ERC20 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed dead code from
LibMath,LibPart,TranferExecutorandRoyaltiesRegistryContracts.Fix error message in
TransferManagerContract.Added tests for
ExchangeContract.Added tests for
OrderValidatorContract.Added tests for
RoyaltiesRegistryContract.