Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange doc #1193

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Exchange doc #1193

merged 2 commits into from
Oct 4, 2023

Conversation

mvanmeerbeck
Copy link
Contributor

Description

Exchange doc

Dev

Any explanation for the devs that will review your implementation/code.

Qa

Any guidance or important information for the team that will be testing your solution.

Note: you can add any additional information you think is important for giving context to your PR.

Checklist and Markdown

  • Remember you could add any type of formatting to enhance your PR.
  • Like this checklist
  • And with this markdown format

@mvanmeerbeck mvanmeerbeck requested a review from a team as a code owner October 3, 2023 18:34
@mvanmeerbeck mvanmeerbeck requested review from atkinsonholly and removed request for a team October 3, 2023 18:34
atkinsonholly
atkinsonholly approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@atkinsonholly atkinsonholly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor clarifications where I've commented, but looks great!

@mvanmeerbeck mvanmeerbeck merged commit 96e65b8 into feat/marketplace-package Oct 4, 2023
4 of 5 checks passed
@mvanmeerbeck mvanmeerbeck deleted the doc/exchange branch October 4, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atkinsonholly atkinsonholly atkinsonholly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvanmeerbeck @atkinsonholly