Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip fee for TSB seller #1186

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Skip fee for TSB seller #1186

merged 8 commits into from
Oct 3, 2023

Conversation

capedcrusader21
Copy link
Contributor

Description

  • Moved Access Control to Transfer Manager
  • Added TSB Wallet role in Transfer Manager
  • Added check to skip fees when seller is TSB Wallet

Link to Jira Issue or relevant doc

Dev

Any explanation for the devs that will review your implementation/code.

Qa

Any guidance or important information for the team that will be testing your solution.

Note: you can add any additional information you think is important for giving context to your PR.

Checklist and Markdown

  • Remember you could add any type of formatting to enhance your PR.
  • Like this checklist
  • And with this markdown format

@capedcrusader21 capedcrusader21 requested a review from a team as a code owner October 2, 2023 12:38
@capedcrusader21 capedcrusader21 requested review from atkinsonholly and removed request for a team October 2, 2023 12:38
@mvanmeerbeck mvanmeerbeck merged commit 1177a53 into feat/marketplace-package Oct 3, 2023
4 of 5 checks passed
@mvanmeerbeck mvanmeerbeck deleted the feat/skip-fee-for-tsb branch October 3, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvanmeerbeck mvanmeerbeck mvanmeerbeck approved these changes

@atkinsonholly atkinsonholly Awaiting requested review from atkinsonholly atkinsonholly was automatically assigned from thesandboxgame/blockchain-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capedcrusader21 @mvanmeerbeck