Feat/enum assetclass #1180
Merged
Feat/enum assetclass #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just the assetClass, maybe some related functio or stil need to be removed
adjisb
requested review from
mvanmeerbeck and
atkinsonholly
and removed request for
a team
atkinsonholly
approved these changes
Oct 2, 2023
mvanmeerbeck
approved these changes
Oct 2, 2023
mvanmeerbeck
reviewed
Oct 2, 2023
| LibOrder.validateOrderTime(order); | ||
|
|
||
| address makeToken = abi.decode(order.makeAsset.assetType.data, (address)); | ||
| verifyWhiteList(makeToken); |
There was a problem hiding this comment.
verifyWhiteList will check ERC20 too and always fail
There was a problem hiding this comment.
verifyERC20Whitelist got lost too
mvanmeerbeck
approved these changes
Oct 2, 2023
mvanmeerbeck
merged commit 2b5ee2c
into
feat/marketplace-initializers
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description