Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: linter and remove some test mocks #1168

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

adjisb
Copy link
Contributor

@adjisb adjisb commented Sep 27, 2023

Description

linter and remove some test mocks

@adjisb adjisb requested a review from a team as a code owner September 27, 2023 22:28
@adjisb adjisb requested review from mvanmeerbeck and atkinsonholly and removed request for a team September 27, 2023 22:28
"custom-errors": "off"
"custom-errors": "off",
"func-named-parameters": ["error", 7],
"reason-string": ["warn", {"maxLength": 64}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to shorten error messages later?

Copy link
Contributor

@atkinsonholly atkinsonholly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See qu on solhint

@@ -6,9 +6,11 @@ import {LibERC1155LazyMint} from "../erc-1155/LibERC1155LazyMint.sol";
import {ECDSAUpgradeable} from "@openzeppelin/contracts-upgradeable/utils/cryptography/ECDSAUpgradeable.sol";
import {EIP712Upgradeable} from "@openzeppelin/contracts-upgradeable/utils/cryptography/draft-EIP712Upgradeable.sol";

// TODO: ERC1155 or ERC721 ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERC1155 ?

@mvanmeerbeck mvanmeerbeck merged commit 59383a4 into feat/remove-backend-signature Sep 28, 2023
3 of 5 checks passed
@mvanmeerbeck mvanmeerbeck deleted the chore/lint-remove-mocks branch September 28, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants