N-05 Asset Audit #1143
Merged
N-05 Asset Audit #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojciech-turek
requested review from
mvanmeerbeck and
atkinsonholly
and removed request for
a team
atkinsonholly
approved these changes
Sep 5, 2023
rishabh0x00
reviewed
Sep 6, 2023
| { | ||
| return ERC1155URIStorageUpgradeable.uri(tokenId); | ||
| } | ||
|
|
||
| function getTokenIdByMetadataHash(string memory metadataHash) public view returns (uint256) { | ||
| function getTokenIdByMetadataHash(string memory metadataHash) public view returns (uint256 tokenId) { |
There was a problem hiding this comment.
The name return variable should also be updated in IAsset.sol for this function.
There was a problem hiding this comment.
Very true, thanks!
|
The changes requested in N-05 is also applicable to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are on purpose not following the guideline.
We believe named exports with explicit returns aid code readability.