Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalyst-audit: N-12 redundant code #1127

Conversation

rishabh0x00
Copy link
Contributor

Description

Catalyst and dependencies audit report fixes
Screenshot from 2023-09-01 17-21-25

Dev

Any explanation for the devs that will review your implementation/code.

Qa

Any guidance or important information for the team that will be testing your solution.

Note: you can add any additional information you think is important for giving context to your PR.

Checklist and Markdown

  • Remember you could add any type of formatting to enhance your PR.
  • Like this checklist
  • And with this markdown format

@rishabh0x00 rishabh0x00 requested a review from a team as a code owner September 1, 2023 11:51
@rishabh0x00 rishabh0x00 requested review from mvanmeerbeck and atkinsonholly and removed request for a team September 1, 2023 11:51
@rishabh0x00 rishabh0x00 force-pushed the catalyst-audit/N-11-public-functions-that-should-have-external-visibility branch from 52625e2 to 66dd01b Compare September 8, 2023 10:57
@rishabh0x00 rishabh0x00 force-pushed the catalyst-audit/N-12-redundant-code branch from cfd4248 to c61fedf Compare September 8, 2023 10:58
…ed-variables

catalyst-audit: N-18 unused variables
…graphical-errors

Catalyst audit: N-14 typographical errors
@rishabh0x00 rishabh0x00 merged commit 61067e9 into catalyst-audit/N-11-public-functions-that-should-have-external-visibility Sep 11, 2023
@mvanmeerbeck mvanmeerbeck deleted the catalyst-audit/N-12-redundant-code branch December 19, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants