Catalyst audit: N-09 Lack of Indexed Event Parameters #1124

rishabh0x00 · 2023-08-31T18:39:03Z

Description

Catalyst and dependencies audit report fixes

Dev

Any explanation for the devs that will review your implementation/code.

Qa

Any guidance or important information for the team that will be testing your solution.

Note: you can add any additional information you think is important for giving context to your PR.

Checklist and Markdown

Remember you could add any type of formatting to enhance your PR.
Like this checklist
And with this markdown format

wojciech-turek

Might need to add indexed on one more event?

packages/dependency-royalty-management/contracts/interfaces/IMultiRoyaltyDistributor.sol

…ed-variables catalyst-audit: N-18 unused variables

…graphical-errors Catalyst audit: N-14 typographical errors

…ndant-code catalyst-audit: N-12 redundant code

…ic-functions-that-should-have-external-visibility Catalyst audit: N-11 public functions that should have external visibility

…ing-calls-to-inherited-contract-initializers Catalyst audit: N-10 Missing Calls to Inherited Contract Initializers

rishabh0x00 requested a review from a team as a code owner August 31, 2023 18:39

rishabh0x00 requested review from mvanmeerbeck and atkinsonholly and removed request for a team August 31, 2023 18:39

wojciech-turek reviewed Sep 1, 2023

View reviewed changes

packages/dependency-royalty-management/contracts/interfaces/IMultiRoyaltyDistributor.sol Show resolved Hide resolved

wojciech-turek force-pushed the catalyst-audit/N-09-lack-of-indexed-event-parameters branch from 1dcddb2 to f711499 Compare September 1, 2023 10:43

wojciech-turek approved these changes Sep 1, 2023

View reviewed changes

Rishabh Sharma and others added 23 commits September 7, 2023 16:42

feat : added events after sensitive changes

63a5fe0

fix : updated missing docstring

1532cea

refactor : enhance function with named return values

4bd0fa2

return the values directly

5595489

refactor : variables names

899aea3

fix : added '_disableInitializers()' in constructor

c810488

fix : updated incomplete docstrings

a4749ac

fix : added indexed params in events

12672d6

fix: removed duplicate constructor

6ae72f9

feat : added events after sensitive changes

85979b2

fix : updated missing docstring

d7b6d5e

refactor : enhance function with named return values

de639e8

return the values directly

a09b5f3

fix : added missing parent initializer calls in contract

608ded4

feat : added events after sensitive changes

19060f8

fix : updated missing docstring

0a7ad20

refactor : enhance function with named return values

18a0221

return the values directly

ad384de

fix : updated functions visibility to external

444b4f0

fix: function visibility

301ca73

fix: updated function visibility

66dd01b

feat : added events after sensitive changes

3a7921f

fix : updated missing docstring

5aa7c28

Rishabh Sharma and others added 21 commits September 8, 2023 15:44

refactor : enhance function with named return values

bacfb0b

return the values directly

9ddbacc

refactor : enhance function with named return values

f19841a

return the values directly

ccc6408

fix : fixed typographical errors

db219fe

Fix typographical errors

e14cfa4

refactor : enhance function with named return values

b95984a

return the values directly

d5d799a

refactor : enhance function with named return values

de75a07

return the values directly

a822c01

refactor : enhance function with named return values

bd489c0

return the values directly

1eb60f2

refactor : used named return royalBps variable

74cdcd8

fix: added missing function

26a6a93

fix: format:fix

920c1e3

refactor : enhance function with named return values

129a667

return the values directly

b87dbe7

fix: added missing function

925452a

fix : removed unused variables

a594e5f

fix: fixed format

2cb5258

refactor: removed royaltyBps value allocation

80d6ba2

rishabh0x00 force-pushed the catalyst-audit/N-08-inconsistent-use-of-named-return-values branch from 3a2c63b to b385c33 Compare September 8, 2023 10:55

rishabh0x00 force-pushed the catalyst-audit/N-09-lack-of-indexed-event-parameters branch from f711499 to 6ae72f9 Compare September 8, 2023 10:56

rishabh0x00 added 5 commits September 11, 2023 18:34

Merge pull request #1130 from thesandboxgame/catalyst-audit/N-18-unus…

fdfdd31

…ed-variables catalyst-audit: N-18 unused variables

Merge pull request #1128 from thesandboxgame/catalyst-audit/N-14-typo…

711d9e0

…graphical-errors Catalyst audit: N-14 typographical errors

Merge pull request #1127 from thesandboxgame/catalyst-audit/N-12-redu…

61067e9

…ndant-code catalyst-audit: N-12 redundant code

Merge pull request #1126 from thesandboxgame/catalyst-audit/N-11-publ…

bf2172b

…ic-functions-that-should-have-external-visibility Catalyst audit: N-11 public functions that should have external visibility

Merge pull request #1125 from thesandboxgame/catalyst-audit/N-10-miss…

083d8fd

…ing-calls-to-inherited-contract-initializers Catalyst audit: N-10 Missing Calls to Inherited Contract Initializers

rishabh0x00 merged commit 943a005 into catalyst-audit/N-08-inconsistent-use-of-named-return-values Sep 11, 2023

mvanmeerbeck deleted the catalyst-audit/N-09-lack-of-indexed-event-parameters branch December 19, 2023 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Catalyst audit: N-09 Lack of Indexed Event Parameters #1124

Catalyst audit: N-09 Lack of Indexed Event Parameters #1124

rishabh0x00 commented Aug 31, 2023 •

edited

Loading

wojciech-turek left a comment

Catalyst audit: N-09 Lack of Indexed Event Parameters #1124

Catalyst audit: N-09 Lack of Indexed Event Parameters #1124

Conversation

rishabh0x00 commented Aug 31, 2023 • edited Loading

Description

Dev

Qa

Checklist and Markdown

wojciech-turek left a comment

Choose a reason for hiding this comment

rishabh0x00 commented Aug 31, 2023 •

edited

Loading