-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalyst audit: M-01 missing overflow check from tryMul function. #1104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a test for the require that you added, otherwise great :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Holly, additional test would do nicely. Would be good to have a passing test and a revert test.
824728f
to
67b6b46
Compare
added the revert test but no need for success test as we already have them for successful splits |
…ed-variables catalyst-audit: N-18 unused variables
…graphical-errors Catalyst audit: N-14 typographical errors
…ndant-code catalyst-audit: N-12 redundant code
…ic-functions-that-should-have-external-visibility Catalyst audit: N-11 public functions that should have external visibility
…ing-calls-to-inherited-contract-initializers Catalyst audit: N-10 Missing Calls to Inherited Contract Initializers
…-of-indexed-event-parameters Catalyst audit: N-09 Lack of Indexed Event Parameters
…nsistent-use-of-named-return-values Catalyst audit: N-08 Inconsistent Use of Named Return Values
…mplete-docstrings Catalyst audit: N-06 Incomplete Docstrings
…bleInitializers-function-not-called-in-multiple-initializable-contract-constructors Catalyst audit: N-05 _disableInitializers() Not Called in Multiple Initializable Contract Constructors
…ract-should-be-abstract Catalyst audit: N-04 Contract Should Be Abstract
…tant-not-using-upper-case-format Catalyst audit: N-03 Constant Not Using UPPER_CASE Format
…ng-style-deviates-from-solidity-style-guide Catalyst audit: N-02 Coding Style Deviates From Solidity Style Guide
…catalyst-contract-allows-the-burning-and-transfer-of-non-existent-tokens Catalyst audit: L-11 The Catalyst Contract Allows the Burning and Transfer of Non-Existent Tokens
…ing-docstrings Catalyst audit: L 10 missing docstrings
…-of-gap-variables Catalyst audit: L 09 lack of gap variables
…-of-event-emission-after-sensitive-action Catalyst audit: L 08 lack of event emission after sensitive action
…ializer-functions-can-be-called-after-initialization Catalyst audit: L-07 initializer functions can be called after initialization
…rrect-documentation Catalyst audit: L-06 incorrect documentation
…mplete-data-in-struct-with-royalty-information Catalyst audit: L-05 incomplete data in struct with royalty information
…0-transfer-return-value-lacks-validation catalyst-audit: L-04 ERC20 transfer return value lacks validation
…oying-royalty-splitter-instance-may-emit-incorrect-recipient-in-event Catalyst audit: L-03 deploying royalty splitter instance may emit incorrect recipient in event
…y-may-contain-duplicate-value Catalyst audit: L-02 array may contain duplicate value
…ract-contracts-allow-direct-modification-of-state-variables Catalyst audit: L-01 Abstract contracts allow direct modification of state variables.
6185c70
into
catalyst-audit/H-02-deploying-royalty-splitter-instance-for-creator-can-be-front-run-allowing-royalties-to-be-stolen
Description
Catalyst and dependencies audit report fixes
Dev
Any explanation for the devs that will review your implementation/code.
Qa
Any guidance or important information for the team that will be testing your solution.
Checklist and Markdown