Skip to content

Commit

Permalink
fix : added '_disableInitializers()' in constructor
Browse files Browse the repository at this point in the history
  • Loading branch information
Rishabh Sharma committed Aug 31, 2023
1 parent 52a729e commit d7304d5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ contract RoyaltyManager is AccessControlUpgradeable, IRoyaltyManager {
address internal _royaltySplitterCloneable;
address internal _trustedForwarder;

/// @dev this protects the implementation contract from behing initialized.
/// @custom:oz-upgrades-unsafe-allow constructor
constructor() {
_disableInitializers();
}

/// @notice initialization function for the deployment of contract
/// @dev called during the deployment via the proxy.
/// @param _commonRecipient the != address(0)common recipient for all the splitters
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ contract RoyaltySplitter is
event ERC20Transferred(address indexed erc20Contract, address indexed account, uint256 amount);
event RecipientSet(address indexed recipientAddress);

/// @dev this protects the implementation contract from behing initialized.
/// @custom:oz-upgrades-unsafe-allow constructor
constructor() {
_disableInitializers();
}

/// @notice Query if a contract implements interface `id`.
/// @param interfaceId the interface identifier, as specified in ERC-165.
/// @return `true` if the contract implements `id`.
Expand Down

1 comment on commit d7304d5

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage for this commit

96.34%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/asset/contracts
   Asset.sol94.53%89.58%96.43%98.08%103, 188, 293, 293–294, 65
   AssetCreate.sol94.51%83.33%100%100%130, 132, 165, 281, 68
   AssetReveal.sol94.35%86.21%96.55%98.89%143, 147, 181, 376, 416, 424, 441, 75, 98
   AuthSuperValidator.sol100%100%100%100%
   Catalyst.sol95%91.94%95.45%98.21%125, 127, 140, 152, 224, 80
packages/asset/contracts/interfaces
   IAsset.sol100%100%100%100%
   IAssetCreate.sol100%100%100%100%
   IAssetReveal.sol100%100%100%100%
   ICatalyst.sol100%100%100%100%
   ITokenUtils.sol100%100%100%100%
packages/asset/contracts/libraries
   TokenIdUtils.sol100%100%100%100%
packages/dependency-metatx/contracts
   ERC2771Handler.sol100%100%100%100%
   ERC2771HandlerAbstract.sol100%100%100%100%
   ERC2771HandlerUpgradeable.sol95.45%83.33%100%100%43
packages/dependency-metatx/contracts/test
   ERC2771HandlerTest.sol100%100%100%100%
   ERC2771HandlerUpgradeableTest.sol100%100%100%100%
   MockTrustedForwarder.sol0%0%0%0%15, 18–19, 19, 19–20
packages/dependency-operator-filter/contracts
   OperatorFiltererUpgradeable.sol82.35%85%71.43%83.33%17, 51–52, 61–62, 71, 83
   OperatorFilterSubscription.sol60%50%100%50%19–20
packages/dependency-operator-filter/contracts/interfaces
   IOperatorFilterRegistry.sol100%100%100%100%
packages/dependency-royalty-management/contracts
   MultiRoyaltyDistributor.sol83.82%65%90%92.11%137, 25, 40, 40, 40, 40, 58–59, 90, 97
   RoyaltyDistributor.sol77.78%50%80%88.89%20, 49, 55
   RoyaltyManager.sol96.43%87.50%100%100%103, 47, 97
   RoyaltySplitter.sol92.16%75%92.31%97.10%120, 160, 189, 217, 68, 75, 85
packages/dependency-royalty-management/contracts/interfaces
   IERC20Approve.sol100%100%100%100%
   IMultiRoyaltyDistributor.sol100%100%100%100%
   IMultiRoyaltyRecipients.sol100%100%100%100%
   IRoyaltyManager.sol100%100%100%100%
   IRoyaltyUGC.sol100%100%100%100%

Please sign in to comment.