Skip to content

Commit

Permalink
Merge pull request #1098 from thesandboxgame/feat/prepare_for_new_sol…
Browse files Browse the repository at this point in the history
…hint

fix: disable solhint custom errors check
  • Loading branch information
adjisb authored Aug 24, 2023
2 parents 604c386 + c546d38 commit b15dfeb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion packages/example-hardhat/.solhint.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
}
],
"compiler-version": ["error", "^0.8.0"],
"func-visibility": ["error", {"ignoreConstructors": true}]
"func-visibility": ["error", {"ignoreConstructors": true}],
"custom-errors": "off"
}
}
3 changes: 2 additions & 1 deletion packages/giveaway/.solhint.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"compiler-version": ["error", "^0.8.0"],
"func-name-mixedcase": "off",
"func-visibility": ["error", {"ignoreConstructors": true}],
"not-rely-on-time": "off"
"not-rely-on-time": "off",
"custom-errors": "off"
}
}

1 comment on commit b15dfeb

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage for this commit

99.40%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/example-hardhat/contracts
   Lock.sol100%100%100%100%
   LockUpgradeable.sol100%100%100%100%
packages/giveaway/contracts
   ERC2771Handler.sol100%100%100%100%
   SignedMultiGiveaway.sol100%100%100%100%
   SignedMultiGiveawayBase.sol100%100%100%100%
packages/giveaway/contracts/test
   FakeMintableERC1155.sol100%100%100%100%
   FakeMintableERC20.sol100%100%100%100%
   FakeMintableERC721.sol100%100%100%100%
   FakeProxy.sol85.71%100%100%75%34

Please sign in to comment.