clean todos

thesandboxgame · Oct 6, 2023 · a52afa5 · a52afa5 · github-actions · Oct 6, 2023
1 parent 08df34a
commit a52afa5
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 13 deletions.
diff --git a/packages/marketplace/contracts/mocks/LibFeeSideTest.sol b/packages/marketplace/contracts/mocks/LibFeeSideTest.sol
@@ -4,7 +4,6 @@ pragma solidity 0.8.21;
 
 import {LibAsset} from "../lib-asset/LibAsset.sol";
 
-// TODO: MAKE THE TESTS!!!
 contract LibFeeSideTest {
     function getFeeSideTest(
         LibAsset.AssetClassType maker,

diff --git a/packages/marketplace/hardhat.config.ts b/packages/marketplace/hardhat.config.ts
@@ -20,8 +20,7 @@ const config: HardhatUserConfig = {
   },
   networks: {
     hardhat: {
-      // TODO remove after size issue is resolved
-      allowUnlimitedContractSize: true,
+      allowUnlimitedContractSize: false,
     },
   },
 };

diff --git a/packages/marketplace/test/exchange/Exchange.test.ts b/packages/marketplace/test/exchange/Exchange.test.ts
@@ -1646,7 +1646,6 @@ describe('Exchange.sol', function () {
     ).to.be.reverted;
   });
   describe('batching', function () {
-    // TODO: Add a lot more tests on batches.
     it('should be able to buy two tokens from different orders in one txs', async function () {
       const {
         ExchangeContractAsUser,
@@ -2247,7 +2246,4 @@ describe('Exchange.sol', function () {
       ]);
     });
   });
-  // TODO
-  // describe("test match from", function () {});
-  // describe("test on pause", function () {});
 });
diff --git a/packages/marketplace/test/exchange/OrderValidator.test.ts b/packages/marketplace/test/exchange/OrderValidator.test.ts
@@ -387,7 +387,4 @@ describe('OrderValidator.sol', function () {
       )
     ).to.be.equal(false);
   });
-  // TODO:
-  // it('should check start / end', async function () {});
-  // it('should check validate through the whitelist', async function () {});
 });
diff --git a/packages/marketplace/test/fixtures.ts b/packages/marketplace/test/fixtures.ts
@@ -1,7 +1,6 @@
 import {ethers, upgrades} from 'hardhat';
 import {ZeroAddress} from 'ethers';
 
-// TODO: Split fixtures so we use only what is needed!!!
 async function deploy() {
   const [deployer, admin, user, defaultFeeReceiver, user1, user2] =
     await ethers.getSigners();

diff --git a/packages/marketplace/test/utils/assets.ts b/packages/marketplace/test/utils/assets.ts
@@ -88,7 +88,6 @@ export const AssetERC721 = async (
       [await tokenContract.getAddress(), tokenId]
     ),
   },
-  // TODO: Test value !=1
   value: 1,
 });
 

diff --git a/packages/marketplace/test/utils/order.ts b/packages/marketplace/test/utils/order.ts
@@ -81,7 +81,6 @@ export const getSymmetricOrder = async (
   return {...ret, maker: o.taker};
 };
 
-// TODO: Test it.
 export function hashOrder(order: Order): string {
   const encoded = AbiCoder.defaultAbiCoder().encode(
     [
-Original file line number
+Diff line change
@@ Expand Up / @@ -88,7 +88,6 @@ export const AssetERC721 = async ( @@
           [await tokenContract.getAddress(), tokenId]
         ),
       },
-      // TODO: Test value !=1
       value: 1,
     });
@@ Expand Down @@
File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/marketplace/contracts/exchange
Exchange.sol	79.71%	70%	87.50%	86.96%	174, 63, 79, 89, 89, 89, 89–90, 90, 90–91, 98
ExchangeCore.sol	84.81%	61.54%	100%	95.45%	118–119, 119, 119, 122, 188, 190, 194, 215–216, 64, 94
OrderValidator.sol	89.29%	84.62%	100%	92%	41, 71–72, 72, 72, 76
WhiteList.sol	97.67%	93.75%	100%	100%	63
packages/marketplace/contracts/exchange/libraries
LibFill.sol	60.87%	33.33%	75%	69.23%	32–33, 58, 68–69, 69, 69–70
LibMath.sol	27.50%	18.75%	50%	30%	100–103, 17–18, 33–34, 50, 50, 50–51, 72, 72, 72–73, 75, 88, 88, 88–89, 93, 93, 93, 93, 93, 97
packages/marketplace/contracts/interfaces
IOrderValidator.sol	100%	100%	100%	100%
IRoyaltiesProvider.sol	100%	100%	100%	100%
IWhiteList.sol	100%	100%	100%	100%
packages/marketplace/contracts/lib-asset
LibAsset.sol	100%	100%	100%	100%
packages/marketplace/contracts/lib-bp
BpLibrary.sol	100%	100%	100%	100%
packages/marketplace/contracts/lib-order
LibOrder.sol	73.33%	50%	100%	100%	64, 64, 66, 66
packages/marketplace/contracts/lib-part
LibPart.sol	0%	100%	0%	0%	21
packages/marketplace/contracts/royalties
IERC2981.sol	100%	100%	100%	100%
LibRoyalties2981.sol	78.57%	50%	100%	88.89%	19–20, 23
packages/marketplace/contracts/royalties-registry
IMultiRoyaltyRecipients.sol	100%	100%	100%	100%
RoyaltiesRegistry.sol	90.40%	85.29%	100%	90.79%	166–167, 170–171, 212, 216, 247, 250, 256, 259, 276, 60
packages/marketplace/contracts/transfer-manager
TransferExecutor.sol	90.48%	75%	100%	100%	24, 30
TransferManager.sol	81.65%	68.97%	100%	87.50%	137, 190, 199, 206–207, 207, 207–208, 212, 220, 227–228, 252, 269, 273–275, 275, 275–277, 282–283, 306, 310–311, 62, 82–83
packages/marketplace/contracts/transfer-manager/interfaces
IRoyaltyUGC.sol	100%	100%	100%	100%
ITransferExecutor.sol	100%	100%	100%	100%
ITransferManager.sol	100%	100%	100%	100%